metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <>
Subject [GitHub] incubator-metron pull request #303: METRON-424 ability to validate ip addres...
Date Tue, 11 Oct 2016 15:03:12 GMT
GitHub user ottobackwards opened a pull request:

    METRON-424 ability to validate ip addresses against both IPV4 and IPV6

    Allow the specification of multiple validation types for IP
         "fieldValidations" : [
           "input" : [ "field1", "field2" ]
           ,"validation" : "IP"
           ,"config" : {
           "type" : ["IPV4","IPV6"]
    The question with this PR is if this is the correct approach.  Is this the most consistent
approach?  Is it the least surprising?  Would it be better to add a ALL keyword such that
instead of specifying both types you can just do
    "type": "BOTH"?
    I did it this way to start, but I'm open to change it based on review.

You can merge this pull request into a Git repository by running:

    $ git pull METRON-424

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #303
commit 9064ec0cdc38c54bf3a5309bad200f1f27d3c00a
Author: Otto Fowler <>
Date:   2016-10-11T14:57:02Z

    METRON-424 ability to validate ip addresses against both IPV4 and IPV6


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message