metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #414: METRON-532 Define Profile Period When Ca...
Date Wed, 11 Jan 2017 16:03:43 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/414#discussion_r95609517
  
    --- Diff: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/GetProfileTest.java
---
    @@ -116,6 +119,33 @@ public void setup() {
                         .build());
       }
     
    +  private Context setup2() {
    --- End diff --
    
    What does `setup2` do differently than `setup`?  Could we comment or rename the function
to be more descriptive?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message