metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] incubator-metron issue #414: METRON-532 Define Profile Period When Calling P...
Date Wed, 11 Jan 2017 17:05:48 GMT
Github user mattf-horton commented on the issue:

    https://github.com/apache/incubator-metron/pull/414
  
    @nickwallen and @cestella, thanks for the comments.  Regarding multiple optional args,
I followed the rule that if the second optional arg is provided, then the first "optional"
arg isn't optional; or more generally, if a later optional arg is provided, all preceding
optional args must also be provided, even if with trivial values.  No tricky polymorphisms
with object types, just a simple argument count. I think that's the best we can do without
named arguments.
    
    BTW, @cestella , my previous PR-345 did use object type checking to allow either or both
to be truly optional, but it felt very hacky, was obviously not generalizable, and I was happy
to change to this.
    
    Hopefully I made this clear for users in both the comments and documents.  Let me know
if you feel more needs to be said.  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message