metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] incubator-metron issue #416: METRON-656: Make Stellar 'in' closer to functio...
Date Fri, 13 Jan 2017 19:30:50 GMT
Github user jjmeyer0 commented on the issue:

    https://github.com/apache/incubator-metron/pull/416
  
    I think this is a great feature. I do have a few suggestions/questions:
    
    1. Does it make sense to start moving away from `StellarTest` and break out into specific
test classes (eg. `StellarArithmeticTest`, `StellarPredicateProcessorTest`, etc.)? Or Should
this be a task in of itself to design a good structure?
    2. I think the tests that are there for `in` should also be run against `not in` as well.

    3. Update the README.md to include a description of how `in` and `not in` should work.
For example, I'm not really sure what I should expect from the expression: `1 in 1111`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message