metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #416: METRON-656: Make Stellar 'in' closer to ...
Date Fri, 13 Jan 2017 20:53:19 GMT
Github user jjmeyer0 commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/416#discussion_r96071886
  
    --- Diff: metron-platform/metron-common/README.md ---
    @@ -39,11 +40,17 @@ The following keywords need to be single quote escaped in order to
be used in St
     | <= | \> | \>= |
     | ? | \+ | \- |
     | , | \* | / |
    +|  | \* | / |
     
     Using parens such as: "foo" : "\<ok\>" requires escaping; "foo": "\'\<ok\>\'"
     
    +## Stellar Language Inclusion Checks (`in` and `not in`)
    +1. `in` supports string contains. e.g. `'foo' in 'foobar' == true`
    +2. `in` supports collection contains. e.g. `'foo' in [ 'foo', 'bar' ] == true`
    +3. `in` supports map key contains. e.g. `'foo' in { 'foo' : 5} == true`
    +4. `not in` is the negation of the in expression. e.g. `'grok' not in 'foobar' == true`
    --- End diff --
    
    Sorry, one last comment. I was a bit curious as to how the expression `'grok' not in 'foobar'
== true` would be evaluated by Stellar. I wasn't sure if it would be `'(grok' not in 'foobar')
== true` or `'grok' not in ('foobar' == true)`.  Unfortunately when I tried to run a test
it said it is not a valid expression. I think this may be an issue in the Stellar grammar.
It is probably outside the scope of this ticket, but I thought I should mention it here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message