metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #316: METRON-503: Metron REST API
Date Fri, 20 Jan 2017 22:42:42 GMT
Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/316#discussion_r97170704
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/GlobalConfigController.java
---
    @@ -0,0 +1,74 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.rest.controller;
    +
    +import io.swagger.annotations.ApiOperation;
    +import io.swagger.annotations.ApiParam;
    +import io.swagger.annotations.ApiResponse;
    +import io.swagger.annotations.ApiResponses;
    +import org.apache.metron.rest.RestException;
    +import org.apache.metron.rest.service.GlobalConfigService;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.http.HttpStatus;
    +import org.springframework.http.ResponseEntity;
    +import org.springframework.web.bind.annotation.RequestBody;
    +import org.springframework.web.bind.annotation.RequestMapping;
    +import org.springframework.web.bind.annotation.RequestMethod;
    +import org.springframework.web.bind.annotation.RestController;
    +
    +import java.util.Map;
    +
    +@RestController
    +@RequestMapping("/api/v1/global/config")
    +public class GlobalConfigController {
    +
    +    @Autowired
    +    private GlobalConfigService globalConfigService;
    +
    +    @ApiOperation(value = "Creates or updates the Global Config in Zookeeper")
    +    @ApiResponse(message = "Returns saved Global Config JSON", code = 200)
    +    @RequestMapping(method = RequestMethod.POST)
    +    ResponseEntity<Map<String, Object>> save(@ApiParam(name="globalConfig",
value="The Global Config JSON to be saved", required=true)@RequestBody Map<String, Object>
globalConfig) throws RestException {
    +        return new ResponseEntity<>(globalConfigService.save(globalConfig), HttpStatus.CREATED);
    --- End diff --
    
    I updated the controllers for global, parser, enrichment and indexing configs.  They now
return 201 if the object doesn't already exist and 200 otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message