metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <>
Subject [GitHub] incubator-metron pull request #421: METRON-283 Migrate Geo Enrichment outsid...
Date Mon, 23 Jan 2017 14:32:39 GMT
Github user cestella commented on a diff in the pull request:
    --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/
    @@ -161,6 +167,7 @@ protected void initializeStellar() {
         stellarContext = new Context.Builder()
                              .with(Context.Capabilities.ZOOKEEPER_CLIENT, () -> client)
                              .with(Context.Capabilities.GLOBAL_CONFIG, () -> getConfigurations().getGlobalConfig())
    +                         .with(Context.Capabilities.GEO_IP, () -> GeoLiteDatabase.INSTANCE)
    --- End diff --
    Since the INSTANCE is static, is there a reason to not just refer to it directly in the
Stellar function rather than adding a capability?  I always envisioned capabilities to be
for configs which were changing at runtime.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message