metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] incubator-metron issue #316: METRON-503: Metron REST API
Date Mon, 23 Jan 2017 19:27:01 GMT
Github user merrimanr commented on the issue:

    https://github.com/apache/incubator-metron/pull/316
  
    @jjmeyer0, just pushed out the commit to separate Services into interfaces and implementations.
 As I created the interfaces there were a few spots that needed some changes.  
    
    First there were several methods in the GrokService that didn't belong there.  These include
methods that support writing grok statements to/from HDFS and updating a sensor parser config
with these statements.  I believe these methods should be in SensorParserConfigService since
they are needed to support writing and reading sensor parser configs.  It should be noted
that these methods can all be removed if we ever move to keeping grok statements in zookeeper
instead of HDFS (see PR #308).
    
    The second is something you alluded to earlier about converting the StormService to a
facade pattern.  I think you are correct there, this service contains 2 different types of
Storm interactions:
    
    - function calls to the Storm REST API
    - functions that are not exposed through the Storm REST API, only through the Storm CLI
    
    I broke this service down into 2 smaller services.  Is that along the lines of what you
were thinking?
    
    I also moved all the constants in various classes to a single constant class.  We don't
have that many right now so it's manageable to keep them in one place.  
    
    Was also thinking we should rename TransformationService to StellarService?  I can see
that evolving to be more generic than just the Stellar hook in the transformation phase of
the parser topology.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message