metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] incubator-metron issue #316: METRON-503: Metron REST API
Date Wed, 25 Jan 2017 01:51:22 GMT
Github user jjmeyer0 commented on the issue:

    https://github.com/apache/incubator-metron/pull/316
  
    @merrimanr this is looking good. I like how you broke out some of the services and started
a constants class. There were two very minor things that I noticed.
    
    1. `@Override` should be used wherever possible on all service class method that implement
an interface.
    2. I don't believe `@Service` is needed on the interfaces.
    
    I continued to test some more endpoints and things are continuing to look good. I still
want to test out some more endpoints.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message