metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #421: METRON-283 Migrate Geo Enrichment outsid...
Date Wed, 25 Jan 2017 12:47:56 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/421#discussion_r97770743
  
    --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/GenericEnrichmentBolt.java
---
    @@ -161,6 +167,7 @@ protected void initializeStellar() {
         stellarContext = new Context.Builder()
                              .with(Context.Capabilities.ZOOKEEPER_CLIENT, () -> client)
                              .with(Context.Capabilities.GLOBAL_CONFIG, () -> getConfigurations().getGlobalConfig())
    +                         .with(Context.Capabilities.GEO_IP, () -> GeoLiteDatabase.INSTANCE)
    --- End diff --
    
    @cestella Capability was left over from earlier testing.  Everything referred to the static
instance anyway for precisely that reason.  Dropped it entirely and removed from the enum.
    
    @dlyle65535 There's not a geo specific bolt, it's an instance of GenericEnrichment. To
the best of my knowledge (and correct me if I'm wrong), you can't grab global configs in the
adapters.  This specific one gets dropped, but the prepare() method references the static
INSTANCE Casey refers to.  Is there somewhere that could live?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message