metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <>
Subject [GitHub] incubator-metron pull request #421: METRON-283 Migrate Geo Enrichment outsid...
Date Wed, 25 Jan 2017 16:16:30 GMT
Github user nickwallen commented on a diff in the pull request:
    --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/geo/
    @@ -0,0 +1,184 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.enrichment.adapters.geo;
    +import com.maxmind.db.CHMCache;
    +import com.maxmind.geoip2.DatabaseReader;
    +import com.maxmind.geoip2.exception.GeoIp2Exception;
    +import com.maxmind.geoip2.model.CityResponse;
    +import com.maxmind.geoip2.record.City;
    +import com.maxmind.geoip2.record.Country;
    +import com.maxmind.geoip2.record.Location;
    +import com.maxmind.geoip2.record.Postal;
    +import org.apache.commons.validator.routines.InetAddressValidator;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.FileSystem;
    +import org.apache.hadoop.fs.Path;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import java.util.HashMap;
    +import java.util.Map;
    +import java.util.Optional;
    +import java.util.concurrent.locks.Lock;
    +import java.util.concurrent.locks.ReentrantReadWriteLock;
    +public enum GeoLiteDatabase {
    +  INSTANCE;
    --- End diff --
    Why did you go with a singleton?  I'm sure you thought through this and there are good
reasons, so just want to understand.  I just don't like the extra burden that using a singleton
brings on (like the extra locking).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message