metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #421: METRON-283 Migrate Geo Enrichment outsid...
Date Wed, 25 Jan 2017 17:26:16 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/421#discussion_r97832200
  
    --- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec ---
    @@ -317,6 +316,8 @@ This package installs the Metron Profiler %{metron_home}
     # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     
     %changelog
    +* Thu Jan 19 2017 Justin Leet <justinjleet@gmail.com> - 0.3.0
    --- End diff --
    
    It is true that apache recommends strongly (or maybe outright forbids) things like author
tags in source code (see [here](https://mail-archives.apache.org/mod_mbox/www-community/200306.mbox/%3C20030609234538.GA22335@lyra.org%3E)
for a discussion, the reasoning was mostly around the author tags not being accurately representative.
    
    For this situation, however, this is a changelog, so it doesn't have the problem of accurate
representation that author tags do.  That being said, it is redundant information because
such information is stored in git.
    
    I'd recommend doing a dev list discussion with a subject that starts with [MENTORS] on
this to see what the ASF wants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message