metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #421: METRON-283 Migrate Geo Enrichment outsid...
Date Wed, 25 Jan 2017 17:56:35 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/421#discussion_r97838709
  
    --- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec ---
    @@ -317,6 +316,8 @@ This package installs the Metron Profiler %{metron_home}
     # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     
     %changelog
    +* Thu Jan 19 2017 Justin Leet <justinjleet@gmail.com> - 0.3.0
    --- End diff --
    
    Hmm, you're right @dlyle65535, we do lose some capabilities by not having the changelog
in there.  You know what would be cool, if we could generate the spec files as part of maven's
`generate-source` and fill in the changelog with the information from git.  Anyway, best of
both worlds kinda thing, but not effort that should be done as part of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message