metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron issue #421: METRON-283 Migrate Geo Enrichment outside of My...
Date Wed, 25 Jan 2017 20:49:44 GMT
Github user justinleet commented on the issue:

    https://github.com/apache/incubator-metron/pull/421
  
    Updated to replace `EnrichmentAdapter.initializeAdapter()` with `EnrichmentAdapter.initializeAdapter(Map<String,
Object> config)`.  Also added `updateAdapter(Map<String, Object> config);`.  Right
now the configs only get used by GeoAdapter, but all adapters can use configs it is passed
as it needs.  All implementing classes have the method updated, but simply ignore the config
param.
    
    This removes the direct dependency of `GenericEnrichmentBolt` on `GeoLiteDatabase`.  It
will simply call init and update to delegate to each adapter what to do (if anything).  Update
is called during `reloadCallback` if global config updates.
    
    I'll want to spin it up again to further validate, but this addresses @nickwallen's catch
on topologies not using geo needing geo data to exist and @dlyle65535's concern about the
`GenericEnrichmentBolt` needing to know about geo for everything.  Now errors should only
occur if a topology using geo data can't find it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message