metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #424: METRON-672: SolrIndexingIntegrationTest ...
Date Thu, 26 Jan 2017 01:03:29 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/424#discussion_r97915042
  
    --- Diff: metron-platform/metron-enrichment/src/test/java/org/apache/metron/enrichment/integration/components/ConfigUploadComponent.java
---
    @@ -38,6 +39,7 @@
       private String enrichmentConfigsPath;
       private String indexingConfigsPath;
       private String profilerConfigPath;
    +  private Optional<Function<ConfigUploadComponent, Void>> postStartCallback
= Optional.empty();
    --- End diff --
    
    Could this just use Consumer instead of Function? Since the second type parameter is Void,
it seems like the Function is just being a Consumer anyway


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message