metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] incubator-metron issue #425: METRON 609 Enhance Mpack to handle single-node ...
Date Thu, 26 Jan 2017 17:55:23 GMT
Github user mattf-horton commented on the issue:

    https://github.com/apache/incubator-metron/pull/425
  
    Thanks, @dlyle65535 .  Couple more comments:
    
    - Also included is the small change proposed in METRON-641 to use {0} instead of {} in
python format strings in kibana_master.py.  It shouldn't be necessary for Python 2.7, but
these are the only usages of the 2.7 behavior, and there's no harm in making it also work
with Python 2.6.
    
    - The biggest deficiency, as far as I'm concerned, is the need to use a different, sparser
template for a single-node "elasticsearch.master.yaml.j2".  Presumably only one or two of
the removed parameters are actually a problem, and presumably even those don't really have
to be removed but simply need a different value.  But it looked like a big job to figure out.
 Perhaps someone more familiar with Elasticsearch would be able to solve it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message