metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] incubator-metron issue #316: METRON-503: Metron REST API
Date Fri, 27 Jan 2017 17:06:09 GMT
Github user jjmeyer0 commented on the issue:

    https://github.com/apache/incubator-metron/pull/316
  
    @merrimanr looks like you will need to resolve some conflicts.
    
    Also, I looked at this some more. It looks like there aren't many unit tests for the service
layer. It seems like it's indirectly tested through the controllers, but I think there is
still some benefit to having unit tests against the services themselves. Before I made this
comment I wanted to work through an example, and I created a test for `KafkaServiceImpl`.
If you want to see that I'd be more than glad to share. Otherwise, I was just thinking we
could inject all dependencies as mocks using PowerMock or Mockito. Then continue to test normally.
This takes things like spring and any external system out of the picture and focuses just
on the implementation of the services.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message