metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #429: METRON-660 [Umbrella] up-to-date version...
Date Tue, 31 Jan 2017 18:40:08 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/429#discussion_r98739265
  
    --- Diff: site-book/bin/generate-md.sh ---
    @@ -190,7 +190,13 @@ cd site-book/src/site/markdown
     # Rewrite hrefs for resource references, using table provided by Maintainers
     for (( i=0; i<${#HREF_REWRITE_LIST[@]} ; i+=2 )) ; do
         echo rewriting href in "${HREF_REWRITE_LIST[$i]}" : "${HREF_REWRITE_LIST[ $(( i +
1 )) ]}"
    -    sed -i '' -e "${HREF_REWRITE_LIST[ $(( i + 1 )) ]}" "${HREF_REWRITE_LIST[$i]}"
    +    if [[ "$OSTYPE" =~ "darwin" ]] ; then
    +        # Macs need an argument after -i option 
    +        sed -i '' -e "${HREF_REWRITE_LIST[ $(( i + 1 )) ]}" "${HREF_REWRITE_LIST[$i]}"
    +    else
    --- End diff --
    
    @JonZeolla thanks for the example pointer.  Fixed.
    
    @james-sirota , yes maybe sorta.  But that's work too, and the on-going nuisance for people
trying to use it isn't adequately balanced for the effort.  I'm almost done with the conversion
to python.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message