metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] incubator-metron issue #430: METRON-658: Updated Grammar to Handle More Uses...
Date Tue, 31 Jan 2017 21:54:57 GMT
Github user jjmeyer0 commented on the issue:

    https://github.com/apache/incubator-metron/pull/430
  
    @nickwallen personally I don't think it should be a separate PR. To me it is just one
of those things that should be cleaned up as we go. My reasoning is that I think we should
encourage clean up as we go with minimal overhead. However, I understand that it is difficult
to read on github. I do agree that I could have been more conscious of the way I made the
commits though. I changed this PR to have two commits,1 with the changes and 1 with the cleanup.
If this is still hard to review, I can split them into two PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message