metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Foley <ma...@apache.org>
Subject METRON-648 GrokWebSphereParserTest and BasicAsaParserTest are not 2017-safe
Date Tue, 03 Jan 2017 21:59:27 GMT
Hi all,
As described in https://issues.apache.org/jira/browse/METRON-648 , these two test modules
are not year-safe, and are suddenly (as of 2017) giving false Travis errors.

I can fix it quickly, but a question for the “owners” of GrokParser:  Do you have an opinion
as to whether the fix should be done by adding "2016" to the testString values in the GrokWebSphereParserTest
test module (easy, and only affects the test module), vs making GrokParser use a Clock object
set to 2016 (more involved, and affecting core code, but allowing for more interesting testing)?

For those interested, BasicAsaParserTest::testShortTimestamp() illustrates the use of Clock
object in the Asa Parser and its test module.

Thanks,
--Matt



Mime
View raw message