metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #412: METRON-647 Parser unit test failures due...
Date Wed, 04 Jan 2017 16:24:53 GMT
GitHub user justinleet opened a pull request:

    https://github.com/apache/incubator-metron/pull/412

    METRON-647 Parser unit test failures due to assumed year values

    Short term fix for the build, along with some cleanup noted in METRON-648 (which was closed
as a dupe of 647).
    
    Two classes are adjusted:
    
    `BasicAsaParserTest:testIp6Addr`: The rawMessage string has been adjusted to include 2016
explicitly.  In addition `assertTrue` has been replaced with `assertEquals` and params put
in correct order.
    
    `GrokWebSphereParserTest`: Tests no longer use explicit timestamps, but instead generate
a timestamp based on the current year (UTC timezone is used, because GrokParser defaults to
UTC if no timezone is explicitly provided). Using current year is not desirable long term
behavior, but the tests now match existing behavior and the build can succeed. In addition
the order of params to `assertEquals` is corrected and values are no longer unnecessarily
coerced.
    
    A follow-on ticket will be created for handling dates in a more robust manner.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/incubator-metron METRON-647

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #412
    
----
commit 713e0297ff324d2a0a478ca89d600b05beb609c1
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-01-04T15:49:10Z

    Altering unit tests to handle it being not 2016

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message