metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] incubator-metron issue #316: METRON-503: Metron REST API
Date Wed, 01 Feb 2017 21:21:00 GMT
Github user jjmeyer0 commented on the issue:

    https://github.com/apache/incubator-metron/pull/316
  
    @merrimanr you are right about guava. I'll remove my uses of it. Plus, Java has a lot
of those functions built in now. No reason I shouldn't use those instead.
    
    I agree that the guava issue should be taken care of separately. Right now, I think we
should allow a user to set an envitonment variable to point to which guava to use (similar
to hibernate and mysql). This will make it easier for us to run it outside of our IDE.
    
    I think your changes look pretty good. Really nice clean up/tests. We've changed a lot,
so I want to do another pass though.
    
    I think we should still have our `HdfsService`. Right now, I think using `FileSystem`
directly works for us. Using Knox is a good idea, but it probably needs to be optional. My
thought is having the service will help us achieve that. You are probably right though. If
we can achieve everything with WebHDFS it's better for our service to use that. This PR is
already really big though. Maybe we can have that as a take away?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message