metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #435: METRON-684: Decouple Timestamp calculati...
Date Fri, 03 Feb 2017 16:49:12 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/435#discussion_r99375854
  
    --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/ProfilePeriod.java
---
    @@ -51,7 +61,7 @@ public ProfilePeriod(long epochMillis, long duration, TimeUnit units)
{
           throw new IllegalArgumentException(format(
                   "period duration must be greater than 0; got '%d %s'", duration, units));
         }
    -
    +    this.timestamp = epochMillis;
    --- End diff --
    
    That's good feedback, agreed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message