metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From james-sirota <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #449: METRON-701 Triage Metrics Produced by th...
Date Mon, 13 Feb 2017 03:26:15 GMT
Github user james-sirota commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/449#discussion_r100719426
  
    --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/KafkaDestinationHandler.java
---
    @@ -0,0 +1,78 @@
    +/*
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + *
    + */
    +
    +package org.apache.metron.profiler.bolt;
    +
    +import org.apache.metron.common.utils.JSONUtils;
    +import org.apache.metron.profiler.ProfileMeasurement;
    +import org.apache.storm.task.OutputCollector;
    +import org.apache.storm.topology.OutputFieldsDeclarer;
    +import org.apache.storm.tuple.Fields;
    +import org.apache.storm.tuple.Values;
    +import org.json.simple.JSONObject;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Handles emitting a ProfileMeasurement to the stream which writes
    + * profile measurements to Kafka.
    + */
    +public class KafkaDestinationHandler implements DestinationHandler, Serializable {
    +
    +  /**
    +   * The stream identifier used for this destination;
    +   */
    +  private String streamId = "kafka";
    +
    +  @Override
    +  public void declareOutputFields(OutputFieldsDeclarer declarer) {
    +    // the kafka writer expects a field named 'message'
    +    declarer.declareStream(getStreamId(), new Fields("message"));
    +  }
    +
    +  @Override
    +  public void emit(ProfileMeasurement measurement, OutputCollector collector) {
    +
    +    try {
    +      JSONObject message = new JSONObject();
    +      message.put("profile", measurement.getDefinition().getProfile());
    +      message.put("entity", measurement.getEntity());
    +      message.put("period", measurement.getPeriod().getPeriod());
    +      message.put("periodStartTime", measurement.getPeriod().getStartTimeMillis());
    +
    +      // TODO How to serialize an object (like a StatisticsProvider) in a form that can
be used on the other side? (Threat Triage)
    +      // TODO How to embed binary in JSON?
    +      message.put("value", measurement.getValue());
    +
    --- End diff --
    
    One of the problems that I see with this approach is that generally you wouldn't ask a
question "do you think that the number of inbound connections from ip X is abnormal for the
past 15 mins.  the question you would ask is the number of inbound connections for ip X abnormal
for a Tuesday at 11.15AM.  To figure out the answer to this question we would have to retrieve
telemetry from historical Tuesday data at 11.15AM and check if our value at hand for right
now is an outlier based on that data.  METRON-690 is designed to make these retrieval patterns
possible.  Because you retrieving values that are potentially more than 24 hours long I am
not sure keeping this data in Kafka is a good idea.  I think you have to retrieve the values
via a multi-get in Hbase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message