metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron issue #438: METRON-686 Record Rule Set that Fired During Th...
Date Wed, 22 Feb 2017 16:35:02 GMT
Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/438
  
    I'm of the opinion that the flattening should be writer-specific and that should be a
function of the writer config with the default to be specified by the writer implementation.
 This way we can have our cake and eat it too.  Also, we could ALREADY be in a situation where
messages aren't flat (imagine a situation where a stellar function returns a map or a list
and it get assigned to a field).  The *only* safe way to do this is to enforce it at the writer,
IMO.  This is one of the stated benefits to extracting writer configs into their own structures.
    
    Regarding existing conventions, this one was around when I joined the project.  I might
be wrong, but it was an early convention.  The reasoning, as I recall, was multi-fold:
    * Solr didn't handle it
    * Interacting with complex structures was deemed to be difficult
    * Indexing nested structures had some performance implications
    
    As to how to move forward, my suggestion is conform to convention for this JIRA and flatten.
 I created a JIRA to track the flattening effort at [METRON-736](https://issues.apache.org/jira/browse/METRON-736)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message