metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tyler Moore <tmo...@goflyball.com>
Subject Re: Code Review - METRON-571
Date Fri, 03 Feb 2017 21:09:26 GMT
Thanks Casey and Justin,

I'll make sure to note it is not ready for merging but needs reviewed.


Regards,

Tyler Moore
Software Engineer
Phone: 248-909-2769
Email: tmoore@goflyball.com <moore.tyler@goflyball.com>


On Fri, Feb 3, 2017 at 1:03 PM, Casey Stella <cestella@gmail.com> wrote:

> Just chiming in, also wanted to thank you for taking it on.  Justin is
> right, the right venue for feedback here is on a pull request submitted via
> github.  The steps roughly are:
>
>    1. Fork https://github.com/apache/incubator-metron.git by going to
>    https://github.com/apache/incubator-metron and clicking on the "Fork"
>    button (make sure you're logged into your github account)
>    2. Make a branch named as your PR (METRON-571)
>    3. do your work and commit your changes to that branch
>    4. push the branch to a remote branch (e.g. git push --set-upstream
>    origin METRON-571)
>    5. Navigate back to https://github.com/apache/incubator-metron and
>    construct a pull request (see
>    https://help.github.com/articles/creating-a-pull-request/)
>
> If you have any questions, let us know and we can help further.  Thanks
> again for contributing to the project and being part of the community.
>
> Best,
>
> Casey
>
> On Fri, Feb 3, 2017 at 12:42 PM, Justin Leet <justinjleet@gmail.com>
> wrote:
>
> > Hi Tyler,
> >
> > Thanks for working on this, it's a great feature to have and I'm glad
> it's
> > getting worked on.
> >
> > I'll let other people hop in if they disagree (given that there's more
> work
> > to be done), but the way I'd get feedback on code like this is just to
> open
> > a pull request on GitHub. It's easier than using the files on the ticket
> > for a variety of reasons, including making it easier to get and see
> updates
> > and fixes to the code. It wouldn't surprise me if there's a bit of
> > discussion on the PR, given that this is a pretty nice to have feature
> that
> > has a bit of nuance that we'll want to discuss as things come together,
> so
> > having it in one place would be great.
> >
> > I would just make sure to mention that it's not ready for merging because
> > you're looking for help and feedback on things like tests.
> >
> > Justin
> >
> > On Fri, Feb 3, 2017 at 12:22 PM, Tyler Moore <tmoore@goflyball.com>
> wrote:
> >
> > > Hey All,
> > >
> > > I attached some work on the JIRA to METRON-571 issue about stellar
> > external
> > > functions.
> > > Could someone please review and maybe give me some insights on test
> > > integration?
> > >
> > > These are the details on the issue and link is provided as well:
> > > > Add stellar keywords for executing local commands
> > > > -------------------------------------------------
> > > >
> > > >                 Key: METRON-571
> > > >                 URL: https://issues.apache.org/
> jira/browse/METRON-571
> > > >             Project: Metron
> > > >          Issue Type: Improvement
> > > >            Reporter: Jon Zeolla
> > > >            Priority: Minor
> > > >         Attachments: ExternalFunctions.java,
> ExternalFunctionsTest.java
> > > >
> > > >
> > > > Stellar should have the ability to execute scripts on a server in
> order
> > > to undertake automated mitigation or alerting.  Perhaps SHELL_EXEC?
> > >
> > > Regards,
> > >
> > > Tyler Moore
> > > Software Engineer
> > > Phone: 248-909-2769
> > > Email: tmoore@goflyball.com <moore.tyler@goflyball.com>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message