metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #468: METRON-744: Allow Stellar functions to b...
Date Wed, 01 Mar 2017 16:13:43 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/468#discussion_r103722138
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/resolver/ClasspathFunctionResolver.java
---
    @@ -65,24 +72,48 @@
      *
      */
     public class ClasspathFunctionResolver extends BaseFunctionResolver {
    -
    -  /**
    -   * The key for a global property that defines one or more regular expressions
    -   * that specify what should be included when searching for Stellar functions.
    -   */
    -  public static final String STELLAR_SEARCH_INCLUDES_KEY = "stellar.function.resolver.includes";
    -
    -  /**
    +  public enum Config {
    +    STELLAR_VFS_PATHS("stellar.function.paths", ""),
    +    /**
    +     * The key for a global property that defines one or more regular expressions
    +     * that specify what should be included when searching for Stellar functions.
    +     */
    +    STELLAR_SEARCH_INCLUDES_KEY("stellar.function.resolver.includes", ""),
    --- End diff --
    
    What would you like to rename it to?  It seems properly named to me, but I'm open to other
names, for sure.  I do intend on documenting it, for sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message