metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JonZeolla <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...
Date Sat, 04 Mar 2017 01:08:26 GMT
Github user JonZeolla commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/470#discussion_r104272021
  
    --- Diff: metron-interface/metron-rest/README.md ---
    @@ -131,11 +131,11 @@ Request and Response objects are JSON formatted.  The JSON schemas
are available
     | [ `GET /api/v1/storm/indexing/deactivate`](#get-apiv1stormindexingdeactivate)|
     | [ `GET /api/v1/storm/indexing/start`](#get-apiv1stormindexingstart)|
     | [ `GET /api/v1/storm/indexing/stop`](#get-apiv1stormindexingstop)|
    -| [ `GET /api/v1/storm/parser/activate/{name}`](#get-apiv1stormparseractivate{name})|
    -| [ `GET /api/v1/storm/parser/deactivate/{name}`](#get-apiv1stormparserdeactivate{name})|
    -| [ `GET /api/v1/storm/parser/start/{name}`](#get-apiv1stormparserstart{name})|
    -| [ `GET /api/v1/storm/parser/stop/{name}`](#get-apiv1stormparserstop{name})|
    -| [ `GET /api/v1/storm/{name}`](#get-apiv1storm{name})|
    +| [ `GET /api/v1/storm/parser/activate/{name}`](#get-apiv1stormparseractivatename)|
    +| [ `GET /api/v1/storm/parser/deactivate/{name}`](#get-apiv1stormparserdeactivatename)|
    +| [ `GET /api/v1/storm/parser/start/{name}`](#get-apiv1stormparserstartname)|
    +| [ `GET /api/v1/storm/parser/stop/{name}`](#get-apiv1stormparserstopname)|
    +| [ `GET /api/v1/storm/{name}`](#get-apiv1stormname)|
    --- End diff --
    
    That sounds good to me, do you want me to revert these back to use `{name}` instead of
`name` in anticipation of your fix?  Or I can leave this in and you can revert as a part of
your fix.  Either way works for me, although I prefer the latter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message