metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #470: METRON-752 Fix documentation typos and M...
Date Sat, 04 Mar 2017 02:04:39 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/470#discussion_r104275074
  
    --- Diff: metron-interface/metron-rest/README.md ---
    @@ -131,11 +131,11 @@ Request and Response objects are JSON formatted.  The JSON schemas
are available
     | [ `GET /api/v1/storm/indexing/deactivate`](#get-apiv1stormindexingdeactivate)|
     | [ `GET /api/v1/storm/indexing/start`](#get-apiv1stormindexingstart)|
     | [ `GET /api/v1/storm/indexing/stop`](#get-apiv1stormindexingstop)|
    -| [ `GET /api/v1/storm/parser/activate/{name}`](#get-apiv1stormparseractivate{name})|
    -| [ `GET /api/v1/storm/parser/deactivate/{name}`](#get-apiv1stormparserdeactivate{name})|
    -| [ `GET /api/v1/storm/parser/start/{name}`](#get-apiv1stormparserstart{name})|
    -| [ `GET /api/v1/storm/parser/stop/{name}`](#get-apiv1stormparserstop{name})|
    -| [ `GET /api/v1/storm/{name}`](#get-apiv1storm{name})|
    +| [ `GET /api/v1/storm/parser/activate/{name}`](#get-apiv1stormparseractivatename)|
    +| [ `GET /api/v1/storm/parser/deactivate/{name}`](#get-apiv1stormparserdeactivatename)|
    +| [ `GET /api/v1/storm/parser/start/{name}`](#get-apiv1stormparserstartname)|
    +| [ `GET /api/v1/storm/parser/stop/{name}`](#get-apiv1stormparserstopname)|
    +| [ `GET /api/v1/storm/{name}`](#get-apiv1stormname)|
    --- End diff --
    
    Your fix is correct for Github-MD; these links were broken there before your changes.
 So please leave them in.  The patch I've now submitted (PR#1 to this branch) fixes site-book/bin/fix-md-dialect.py
to correctly handle slashes and curly braces (and all other non-alphanumerics) in the link
label text, so they'll be okay in site-book too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message