metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #436: METRON-671: Refactor existing Ansible de...
Date Tue, 07 Mar 2017 00:14:33 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/436#discussion_r104558938
  
    --- Diff: metron-deployment/roles/metron-builder/tasks/main.yml ---
    @@ -15,4 +15,7 @@
     #  limitations under the License.
     #
     ---
    -hdp_repo_def: "http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.5.0.0/hdp.repo"
    +- name: Build Deployment Artifacts
    +  local_action: shell cd {{ metron_build_dir }} && mvn clean package -DskipTests
-P HDP-2.5.0.0,mpack,build-rpms
    --- End diff --
    
    Maybe something like...
    ```
    - name: Build Deployment Artifacts
       local_action: shell cd {{ metron_build_dir }} && mvn clean package -DskipTests
-P HDP-2.5.0.0,mpack,build-rpms
       become: false
       run_once: true
       ignore_errors: yes
       register: results
    
    - fails: msg="Failed to build Metron... Is Docker Running?  <Link to README?>"
       when: results.rc != 0
    ```
    
    Or could we splits the Metron build into multiple steps?  First do the `mvn clean package`.
 Then build the RPMS in a second step (the step that adds the Docker dependency) , so we know
more concretely when the issue is likely to be that Docker not installed or not running?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message