metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #436: METRON-671: Refactor existing Ansible de...
Date Tue, 07 Mar 2017 13:31:09 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/436#discussion_r104665126
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml
---
    @@ -27,6 +27,14 @@
             <description>Cluster name identifies your cluster</description>
         </property>
         <property>
    +        <name>masters_also_are_datanodes</name>
    +        <value>"false"</value>
    --- End diff --
    
    No, it's not that important.  Can you add to the description that it has to be in quotes
for ES compatibility?  I can definitely see that causing confusion otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message