metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #474: METRON-758: HdfsServiceImplTest should s...
Date Tue, 07 Mar 2017 17:20:04 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/474#discussion_r104725400
  
    --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/HdfsServiceImplTest.java
---
    @@ -65,6 +66,7 @@ public void listShouldListFiles() throws Exception {
             FileUtils.writeStringToFile(new File(testDir, "file2.txt"), "value2");
     
             List<String> paths = hdfsService.list(new Path(testDir));
    +        Collections.sort(paths, String::compareTo);
    --- End diff --
    
    This is nitpicky, but why even specify String::compareTo? Collections.sort(paths) uses
compareTo by default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message