metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #486: METRON-793: Migrate to storm-kafka-clien...
Date Wed, 22 Mar 2017 14:37:12 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/486#discussion_r107429992
  
    --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/Deserializers.java
---
    @@ -16,31 +16,35 @@
      * limitations under the License.
      */
     
    -package org.apache.metron.spout.pcap.scheme;
    +package org.apache.metron.spout.pcap.deserializer;
     
    -import org.apache.storm.spout.MultiScheme;
    +import org.apache.metron.common.utils.timestamp.TimestampConverters;
     import org.apache.metron.common.utils.timestamp.TimestampConverter;
    -import org.apache.storm.kafka.KeyValueSchemeAsMultiScheme;
     
    -public enum TimestampScheme {
    -   FROM_KEY( converter -> new KeyValueSchemeAsMultiScheme(new FromKeyScheme().withTimestampConverter(converter)))
    -  ,FROM_PACKET(converter -> new FromPacketScheme().withTimestampConverter(converter));
    +import java.util.function.Function;
    +
    +public enum Deserializers {
    --- End diff --
    
    It's worth noting here that the new spout does not use multischemes.  We are doing a fair
bit of byte munging on data coming into the pcap topology in those multischemes, but the abstraction
was clunky.  This makes things a bit clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message