metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <>
Subject [GitHub] incubator-metron pull request #486: METRON-793: Migrate to storm-kafka-clien...
Date Fri, 24 Mar 2017 14:26:12 GMT
Github user justinleet commented on a diff in the pull request:
    --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/
    @@ -106,19 +105,22 @@ public static TopologyBuilder build(String zookeeperUrl,
        * Create a spout that consumes tuples from a Kafka topic.
    -   * @param zookeeperUrl            Zookeeper URL
    +   * @param zkQuorum Zookeeper URL
        * @param sensorType              Type of sensor
    -   * @param offset                  Kafka topic offset where the topology will start;
    -   * @param kafkaSpoutConfigOptions Configuration options for the kafka spout
    +   * @param kafkaConfigOptional     Configuration options for the kafka spout
        * @param parserConfig            Configuration for the parser
        * @return
    -  private static KafkaSpout createKafkaSpout(String zookeeperUrl, String sensorType,
SpoutConfig.Offset offset, EnumMap<SpoutConfigOptions, Object> kafkaSpoutConfigOptions,
SensorParserConfig parserConfig) {
    +  private static StormKafkaSpout createKafkaSpout(String zkQuorum, String sensorType,
Optional<Map<String, Object>> kafkaConfigOptional, SensorParserConfig parserConfig)
    --- End diff --
    StormKafkaSpout's return type here will actually be StormKafkaSpout<Object, Object>,
right?  Can we make that explicit, rather than untyped (and also drop the Object.class from
the creates assuming the other typing change)?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message