metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #488: METRON-796: Mpack uses wrong group for o...
Date Fri, 24 Mar 2017 17:44:46 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/488#discussion_r107961358
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
    @@ -39,7 +39,7 @@
     tmp_dir = Script.get_tmp_dir()
     
     hostname = config['hostname']
    -metron_group = config['configurations']['cluster-env']['metron_group']
    +hadoop_group = config['configurations']['cluster-env']['user_group']
    --- End diff --
    
    I'll go ahead and move the config.
    
    On the group issue, that is the group named 'hadoop'.  The cluster level config is named
'user_group', I have absolutely no idea why. I only called it 'hadoop_group' here, so it was
more obvious it shouldn't be killed in the future.  If there are objections to calling it
'hadoop_group', I could also carry it through as user_group and add a comment about the meaning
in the params file.
    
    For example, in HDP stack https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml#L158
    ```
        <name>user_group</name>
        <display-name>Hadoop Group</display-name>
        <value>hadoop</value>
        <property-type>GROUP</property-type>
        <description>Hadoop user group.</description>
    ```
    
    This declaration carried through a couple other stack definitions that I looked at.
    
    The use of this group also seems fairly common, e.g. in https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py#L60
    ```
      if "hadoop-policy" in params.config['configurations']:
        XmlConfig("hadoop-policy.xml",
                  conf_dir=params.hadoop_conf_dir,
                  configurations=params.config['configurations']['hadoop-policy'],
                  configuration_attributes=params.config['configuration_attributes']['hadoop-policy'],
                  owner=params.hdfs_user,
                  group=params.user_group
        )
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message