metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] incubator-metron issue #488: METRON-796: Mpack uses wrong group for owning H...
Date Fri, 24 Mar 2017 20:31:58 GMT
Github user mattf-horton commented on the issue:

    https://github.com/apache/incubator-metron/pull/488
  
    Thanks.  Looks okay to me now, for the intended purpose.  +0 due to Simon's concerns;
I'd prefer someone with more experience in Metron give you the plus one.
    
    Regarding @simonellistonball 's comments:
    The prior assignment of group ownership as `metron_group` in enrichment_commands.py, line
114, and indexing_commands.py, line 104, dates from the commit for 
    * [METRON-671 Refactor existing Ansible deployment to use Ambari MPack (dlyle via justinleet)#436](https://github.com/justinleet/incubator-metron/commit/68a334a8717d2a6b82f7f9651c57bc75e256ba97)
    Prior to PR#436 they were both set to `user_group`.
    
    @dlyle65535 are you okay with setting these back to `user_group`, as they were before?
    ie do you agree with @justinleet 's reasoning?  Thanks.
    
    @justinleet , you say: "Other items, such as configs and installation files, were just
left as the metron group."  Why is this okay?  Don't the topologies have to read config files
too?  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message