metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #489: METRON-623: Management UI
Date Fri, 31 Mar 2017 14:13:27 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/489#discussion_r109167480
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/GrokController.java
---
    @@ -53,4 +54,11 @@
         ResponseEntity<Map<String, String>> list() throws RestException {
             return new ResponseEntity<>(grokService.getCommonGrokPatterns(), HttpStatus.OK);
         }
    +
    +    @ApiOperation(value = "Retrieves a Grok statement from the classpath")
    +    @ApiResponse(message = "Grok statement", code = 200)
    +    @RequestMapping(value = "/get/statement", method = RequestMethod.GET)
    --- End diff --
    
    Is there a reason why this is only going to the classpath to retrieve the grok statement?
 We can store grok statements on HDFS, afterall.  Shouldn't this match the implementation
in `GrokParser.openInputStream()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message