metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #469: DO NOT MERGE METRON-745: Create Error Da...
Date Thu, 02 Mar 2017 17:25:29 GMT
GitHub user justinleet opened a pull request:

    https://github.com/apache/incubator-metron/pull/469

    DO NOT MERGE METRON-745: Create Error Dashboards

    # DO NOT MERGE
    
    ## Summary
    Based on Ryan's work in https://github.com/apache/incubator-metron/pull/453, I went ahead
and created some a Kibana dashboard for tracking errors.  **That PR is not finalized in master
so this should not be merged!** However, the data flowing to the index is pretty final, so
unless the actual fields or field names change, it doesn't really affect this.
    
    All we care about here is the dashboard itself, but unfortunately the 453 changes get
pulled along for the ride until that's in.
    
    It's nothing too complicated, essentially just some high level overviews of the various
fields output by Ryan (some counts, etc.), along with a pane for viewing the actual errors
along with all their fields.  Note that they include both raw and unique message counts (via
the hash fields) in most things.
    
    I've attached some screenshots, but this can be also be spun up on an Ambari cluster (and
will eventually have to be to be validated, given that the file isn't in a readable format).
    
    I'm basically looking for feedback on what else would be useful and if we want to adjust
anything.  Keep in mind, we don't actually have a lot of fields to work with (because if everything
was good, we wouldn't be here in the first place!). See error_index.template for the fields
we have.
    
    ### Notes
    * I'm really not convinced the 'hostname' visualizations are needed.  The field is there
and useful, but given that it's populated with the Storm host that failed, it seems like it's
probably useless most of the time.
    * Kibana occasionally rearranges the order of the visualizations (usually swapping a couple
of the charts).  If I recall correctly, that's a known Kibana bug that we're stuck with.
    * The graph teaches a lesson of "Don't load all your data at once if you want a pretty
graph". Still, it's just a basic graph of the error counts over time.
    * Keep in mind the graph shifts by the viewing window.  So last 15 minutes vs last 7 days
all updates accordingly.
    
    <img width="1440" alt="errordashboard_top" src="https://cloud.githubusercontent.com/assets/5077341/23518699/52eb58bc-ff42-11e6-912c-cc596fe46a3d.png">
    <img width="1436" alt="errordashboard_middle" src="https://cloud.githubusercontent.com/assets/5077341/23518700/549c3f0a-ff42-11e6-8e26-18553ce804bc.png">
    <img width="1440" alt="errordashboard_bottom" src="https://cloud.githubusercontent.com/assets/5077341/23518702/5605c69a-ff42-11e6-8c76-15f485253e8f.png">
    
    The bottom pane extends further down, but we've all seen a table of data before.
    
    ### For all changes:
    - [] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root incubating-metron folder via:
    
    ```
    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via site-book/target/site/index.html.
    
    ```
    cd site-book
    bin/generate-md.sh
    mvn site:site
    
    ```
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommened that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/incubator-metron dashboards-695

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #469
    
----
commit 4a329ed241f60057136de00e1d716fb81d32d337
Author: rmerriman <rmerriman@hortonworks.com>
Date:   2017-02-06T21:19:45Z

    Initial commit

commit a05fdcdd56ff4c1ee33a643ec065be352d88cd3b
Author: rmerriman <rmerriman@hortonworks.com>
Date:   2017-02-06T21:20:24Z

    Merge remote-tracking branch 'mirror/master' into METRON-695

commit a24e621d79a105ebe1a1c69d0fb1601d7940f96b
Author: rmerriman <rmerriman@hortonworks.com>
Date:   2017-02-08T00:22:16Z

    Updated tests to include error conditions

commit 6b897d5afadde00870e2579af9c3c57d9ef9d076
Author: rmerriman <rmerriman@hortonworks.com>
Date:   2017-02-08T00:22:47Z

    Added error topology to Ambari MPack

commit db09b2932f58e81fd1298e5aef84b59e57286f98
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-02-09T16:40:37Z

    Error dashboards + minor fixes

commit b621fda42c7b220be592a6010117efaa4e8711c6
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-02-09T16:43:51Z

    Change dashboard name

commit 437561af3962f91bccd40140bf8021cdf7105b97
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-02-27T14:23:56Z

    Updating template with more final field names, and updating dashboard appropriately

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message