metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #485: METRON-771 Stellar INDEXING_SET_BATCH in...
Date Mon, 20 Mar 2017 23:09:05 GMT
GitHub user mattf-horton opened a pull request:

    https://github.com/apache/incubator-metron/pull/485

    METRON-771 Stellar INDEXING_SET_BATCH incorrectly defaults batchSize to 5

    Simple couple-line fix for the defaulting behavior.  The only non-comment line is changing
the default from 5 to 1, and adding a validity check.  Found by inspection, and recommend
checking the same.
    
    If one is so inclined, you can do a before-and-after test by invoking
    ```
    INDEXING_SET_BATCH('{}', 'hdfs')
    ```
    in the REPL, leaving out the "size" argument (which is optional, even tho not documented
as such).  Observe the returned JSON of the config, and see what the value of batchSize is.
 Before this patch, it will be 5, after it will be 1.
    
    BTW, with @cestella 's help, we figured out you can invoke the REPL from the build environment
with these steps:
    - build the whole project, eg with `mvn clean install -DskipTests`
    - cd metron-platform/metron-common
    - invoke:
    ```
    java -cp ../metron-enrichment/target/metron-enrichment-0.3.1-uber.jar:../metron-data-management/target/metron-data-management-0.3.1.jar:target/metron-common-0.3.1.jar:../metron-management/target/metron-management-0.3.1.jar:../metron-parsers/target/metron-parsers-0.3.1-uber.jar
org.apache.metron.common.stellar.shell.StellarShell
    ```
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron (Incubating).  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [NA] Have you written or updated unit tests and or integration tests to verify your
changes?
    - [NA] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [NA] Have you verified the basic functionality of the build by building and running
locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattf-horton/incubator-metron METRON-771

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #485
    
----
commit 852543a88ab6159ba541fb43db5d293915de225c
Author: mattf-horton <mfoley@hortonworks.com>
Date:   2017-03-16T21:40:19Z

    METRON-771 Stellar INDEXING_SET_BATCH incorrectly defaults batchSize to 5

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message