metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <>
Subject [GitHub] incubator-metron pull request #489: METRON-623: Management UI
Date Wed, 05 Apr 2017 21:39:00 GMT
Github user merrimanr commented on a diff in the pull request:
    --- Diff: metron-interface/metron-config/src/app/login/login.component.spec.ts ---
    @@ -0,0 +1,65 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +import {async, inject, TestBed} from '@angular/core/testing';
    +import {AuthenticationService} from '../service/authentication.service';
    +import {LoginComponent} from './login.component';
    +class MockAuthenticationService {
    --- End diff --
    Right now each test contains it's own mock classes.  I agree that we should have a common
set of mock services, will make the tests much easier to read and will also make it easier
to write tests in the future.  
    This is not a trivial amount of work because the mocks are a little different between
tests in some cases.  Would it be acceptable to do this work in a follow up Jira?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message