metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #489: METRON-623: Management UI
Date Wed, 05 Apr 2017 21:47:43 GMT
Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/489#discussion_r110036136
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/GrokController.java
---
    @@ -53,4 +54,11 @@
         ResponseEntity<Map<String, String>> list() throws RestException {
             return new ResponseEntity<>(grokService.getCommonGrokPatterns(), HttpStatus.OK);
         }
    +
    +    @ApiOperation(value = "Retrieves a Grok statement from the classpath")
    +    @ApiResponse(message = "Grok statement", code = 200)
    +    @RequestMapping(value = "/get/statement", method = RequestMethod.GET)
    --- End diff --
    
    We have a '/api/v1/hdfs/{path}" endpoint that returns hdfs file contents.  That's the
first call the client side makes.  If that fails, it calls '/api/v1/grok/get/statement' to
get the pattern from the classpath.  If that fails it reports an error in the UI.
    
    We could change '/api/v1/grok/get/statement' to check HDFS first and change the client
side logic to only call the grok endpoint.  Does that make more sense to you and do you think
it's worth making that change?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message