metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #518: METRON-799: The MPack should function in...
Date Fri, 07 Apr 2017 13:13:46 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/518#discussion_r110385969
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
    @@ -131,47 +153,35 @@ def init_geo(self):
             self.set_geo_configured()
     
         def init_kafka_topics(self):
    -        Logger.info('Creating Kafka topics')
    -        command_template = """{0}/kafka-topics.sh \
    -                                --zookeeper {1} \
    -                                --create \
    -                                --topic {2} \
    -                                --partitions {3} \
    -                                --replication-factor {4} \
    -                                --config retention.bytes={5}"""
    -        num_partitions = 1
    -        replication_factor = 1
    -        retention_gigabytes = int(self.__params.metron_topic_retention)
    -        retention_bytes = retention_gigabytes * 1024 * 1024 * 1024
    -
    -        Logger.info("Creating topics for enrichment")
    -        topics = [self.__enrichment_topic]
    -        for topic in topics:
    -            Logger.info("Creating topic'{0}'".format(topic))
    -            Execute(command_template.format(self.__params.kafka_bin_dir,
    -                                            self.__params.zookeeper_quorum,
    -                                            topic,
    -                                            num_partitions,
    -                                            replication_factor,
    -                                            retention_bytes))
    -
    -        Logger.info("Done creating Kafka topics")
    +        Logger.info('Creating Kafka topics for enrichment')
    +        # All errors go to indexing topics, so create it here if it's not already
    +        metron_service.init_kafka_topics(self.__params, [self.__enrichment_topic, self.__params.metron_error_topic])
             self.set_kafka_configured()
     
    +    def init_kafka_acls(self):
    +        Logger.info('Creating Kafka topics')
    --- End diff --
    
    Yes, yes I did.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message