metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JonZeolla <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #510: METRON-821 Minor fixes in full dev kerbe...
Date Wed, 19 Apr 2017 23:22:05 GMT
GitHub user JonZeolla reopened a pull request:

    https://github.com/apache/incubator-metron/pull/510

    METRON-821 Minor fixes in full dev kerberos setup instructions

    ## Contributor Comments
    As I ran through Kerberos-setup.md I found [one minor issue](https://github.com/apache/incubator-metron/blame/eb209f5c9400b81720a866ef5dd1817f73226f44/metron-deployment/vagrant/Kerberos-setup.md#L138),
so I figured that if I was going to make a change I might as well make some other adjustments.
 
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron (Incubating).  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [X] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      bin/generate-md.sh
      mvn site:site
      ```
    Note:  I only reviewed the relevant `target/site/metron-deployment/vagrant/Kerberos-setup.html`
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JonZeolla/incubator-metron METRON-821

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #510
    
----
commit 5dd65bb30eccca25cb5b76a96a38af56f61139b8
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-04T20:37:00Z

    Update Kerberos-setup.md documentation

commit f93c8e24aa840d0e61c90c1e88769a3278752108
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-04T20:43:21Z

    This typo has been driving me crazy

commit 70a4bfd2b41e9aa688fad82f6e6f257c691943c2
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-05T01:03:06Z

    Minor adjustments

commit 624fdf8de43508d350aa73cdb8c1039fd137a448
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-05T21:23:29Z

    Merge branch 'master' of https://github.com/apache/incubator-metron into METRON-821

commit f7d2ba50450c311f9fe325450264f7df0ea376f2
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-05T21:29:42Z

    Update README according to feedback

commit 9fa4353285a3440a53bfe8e92954a119ffbcc493
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-12T15:32:10Z

    Update based on PR feedback, adjust spacing

commit 2491b45466b20995194c765aadd0d71638f3bbde
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-12T15:32:32Z

    Fix 'are you sure' due to cp alias

commit d45fc8fe466fcf6b362887b6b294e050ba5b99bb
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-13T15:28:35Z

    Minor semantic changes and update to 0.4.0 from 0.3.1

commit 5fe0ed7cc14adbfeb7ac07cce4fd4cb041b7f587
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-13T15:30:53Z

    Change from yaf to bro for testing on steps 24 and 25

commit 10502ef1b214abe0e8b0e29ccc284a42aa33eb34
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-13T17:15:44Z

    Change to use integration test data so differentiating from sensor-stubs is easier

commit 62c1c9b2de576b57daa7552218ef7c1fb929585c
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-13T17:22:22Z

    Fix formatting for GitHub and Doxia docs

commit fa45ab09fc1ca9a3489dcb45f2c24424f6ee11fa
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-13T17:50:33Z

    Merge branch 'master' of https://github.com/apache/incubator-metron into METRON-821

commit 030d5951466fe7027068fbca617ce9866eff18fb
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-13T18:20:09Z

    Revert to for loop for sensor-stub restarts

commit f400af3b0cc3ccd7cac05c0adc1c4a65b27f1d58
Author: Jon Zeolla <zeolla@gmail.com>
Date:   2017-04-17T20:07:53Z

    Superficial modification

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message