metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zezutom <...@git.apache.org>
Subject [GitHub] metron pull request #572: METRON-633: Create better logging for HbaseEnrichm...
Date Thu, 01 Jun 2017 21:11:59 GMT
Github user zezutom commented on a diff in the pull request:

    https://github.com/apache/metron/pull/572#discussion_r119730181
  
    --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java
---
    @@ -169,16 +188,19 @@ public HTableInterface getTable(Map<String, Object> config)
throws IOException {
       private List<String> getColumns(Object keyColumnsObj, boolean allowNull) {
         Object o = keyColumnsObj;
         if(allowNull && keyColumnsObj == null) {
    +      LOG.debug("No key columns were specified");
           return Collections.emptyList();
         }
         if(o instanceof String) {
    +      LOG.debug("Key column: '" + o + "'");
    --- End diff --
    
    Thanks everyone for a great feedback! @justinleet I will rebase once #599 is merged, cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message