metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #602: METRON-906: Rest service storm configuration does ...
Date Tue, 06 Jun 2017 13:54:17 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/602#discussion_r120366655
  
    --- Diff: metron-deployment/roles/ambari_config/vars/single_node_vm.yml ---
    @@ -102,7 +102,7 @@ configurations:
     
     required_configurations:
       - metron-env:
    -      storm_rest_addr: "{{ groups.ambari_slave[0] }}:8744"
    +      storm_rest_addr: "http://{{ groups.ambari_slave[0] }}:8744"
    --- End diff --
    
    It probably shouldn't be.  I did that before the backwards compatibility commit.  It'll
be assumed at the code level if no protocol is there anyway, so do we have a preference on
explicit vs. implicit?
    
    It seems more like I need documentation around changing that parameter when storm https
is enabled (both non-Ambari and Ambari need it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message