metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...
Date Tue, 06 Jun 2017 13:56:18 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/607#discussion_r120367143
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
---
    @@ -49,6 +44,11 @@ public StormStatusServiceImpl(Environment environment, RestTemplate
restTemplate
       }
     
       @Override
    +  public SupervisorSummary getSupervisorSummary(){
    +    return restTemplate.getForObject("http://" + environment.getProperty(STORM_UI_SPRING_PROPERTY)
+ SUPERVISOR_SUMMARY_URL, SupervisorSummary.class);
    --- End diff --
    
    https://github.com/apache/metron/pull/602 changes how that works slightly.  Whichever
one goes in second will need to adjust for the other one (which shouldn't be much work either
way).  I don't have a preference on ordering, personally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message