metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions
Date Wed, 07 Jun 2017 13:10:51 GMT
Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/530
  
    
    > @nickwallen: Or did you submit this to get buy-in as a proof-of-concept, that we
can then break down into multiple, smaller PRs, get reviewed and then merged into master?
    I feel like the second would be a good approach for this one.
    
    > @ottobackwards: The answer is 1. I did not submit until this set of functionality
was done because it is completely end to end testable.
    
    I really think we should break this apart into multiple PRs.  Each with their own documented
test plan.  I don't think we are going to get a review of sufficient quality without it. 
I am open to however you think it should be broken apart and can offer my own suggestion on
breaking it apart should you need.
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message