metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar
Date Wed, 07 Jun 2017 13:42:49 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/606#discussion_r120628075
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java
---
    @@ -40,14 +40,22 @@
     import static java.lang.String.format;
     
     public class StellarCompiler extends StellarBaseListener {
    -  private static Token<?> EXPRESSION_REFERENCE = new Token<>(null, Object.class);
    -  private static Token<?> LAMBDA_VARIABLES = new Token<>(null, Object.class);
    +  private static Token<?> EXPRESSION_REFERENCE = new Token<>(null, Object.class,
null);
    +  private static Token<?> LAMBDA_VARIABLES = new Token<>(null, Object.class,
null);
     
       private Expression expression;
       private final ArithmeticEvaluator arithmeticEvaluator;
       private final NumberLiteralEvaluator numberLiteralEvaluator;
       private final ComparisonExpressionWithOperatorEvaluator comparisonExpressionWithOperatorEvaluator;
     
    +  public static class ShortCircuitFrame {}
    +  public static class ShortCircuitOp {}
    --- End diff --
    
    Sorry, one of them can definitely be an interface.  I made the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message