metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions
Date Wed, 07 Jun 2017 15:53:19 GMT
Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/530
  
    @nickwallen I did consider staging the PR's close to what you suggested at various points
( this is my 3rd re-write of this functionality ( Ansible + just packages, RPM + just packages,
RPM + NAR/Bundle ).  
    
    I was however concerned with submitting a small PR, which didn't break the PR master build/functional
requirements, yet had enough context to be reviewable and worth reviewing.  And writing a
parallel deployment/rpm/ambari install did not seem like a good idea.  My understanding was
and is that each PR should be fully functional by the PR criteria.  Thus I broke it up as
I did between capabilities and user facing.
    
    From your breakup:
    1) would have had to have been just the NAR stuff, out of context
    2) **was** split out as METRON-942 in a sense.
    3-4) cannot be done separately while maintaining a working metron
    
    If we were at the beginning, and had discussed the feature branch etc, I am sure we would
progress that way and deal with the broken builds and have the reviewable chunks.
    
    But we are not. I will do whatever I can to address concerns and move this along, I am
not sure that the effort to rework this and the dependent branches ( which would be quite
a bit of work at this point ) is worth while.
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message