metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron issue #579: METRON-941 fix PaloAltoParser
Date Wed, 07 Jun 2017 18:00:50 GMT
Github user mattf-horton commented on the issue:

    https://github.com/apache/metron/pull/579
  
    First, a note to @ctramnitz : Christian, please be patient with the long cycle on this.
 It is not a reflection on your work, but rather a desire to make sure that work gets appropriate
consideration.  Your work is very much appreciated.  We really do have a very strong bias
in Apache toward test-driven development, and so we tend to ask that new work provide unit
tests, even if those tests were lamentably lacking before the new work :-)
    
    Anyway, thanks to fast work by @justinleet , METRON-962 is now in, and the PaloAlto parser
can be unit tested.  Please rebase so it can be done.  Since the one file you changed has
not been touched by recent commits, the rebase should be painless.  If you're not familiar
with git rebase, ping me offline.
    
    If my understanding of Justin's PR is correct, you can then just layer on his bf8ce62
patch, and have a good start on testability.  @justinleet is that correct?  Was it your intent
that this patch will fully provide the unit testing capability, or is it just the start? 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message